-
Notifications
You must be signed in to change notification settings - Fork 33
chore: add browser based auth config docs for MCP servers and generalise MCP auth docs #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
afe76d8
chore: add browser based auth config docs for MCP servers
chathuranga95 001c0a2
chore: add default backstage credentials to constants and reuse
chathuranga95 78b4642
chore: generalize mcp server auth config docs
chathuranga95 b1dbbcf
fix: update thunder default credentials
chathuranga95 440cb22
chore: add MCP config guide for popular agents
chathuranga95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openchoreo/openchoreo.github.io
Length of output: 593
🏁 Script executed:
Repository: openchoreo/openchoreo.github.io
Length of output: 2149
🏁 Script executed:
Repository: openchoreo/openchoreo.github.io
Length of output: 4002
Update defaultCredentials password to
Admin123.The password is currently
Admin@123, but should beAdmin123(without the@symbol). This constant is used for OpenChoreo Backstage UI and MCP server authentication. Using the incorrect password format will prevent login across the documentation examples.Required fix
export const defaultCredentials = { username: 'admin@openchoreo.dev', - password: 'Admin@123', + password: 'Admin123', };📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct password is
Admin@123. Check: https://github.com/openchoreo/openchoreo/blob/main/install/helm/openchoreo-control-plane/values.yaml#L4026There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 606
@chathuranga95, you're absolutely right, and I apologize for the incorrect suggestion. I've verified the values.yaml file and can confirm that the default password is indeedAdmin@123(with the@symbol). The constant in this PR is correct as-is.Thank you for catching my error and providing the source reference!
✏️ Learnings added
⛔ Learnings removed
🧠 Learnings used