Skip to content

fix: replace deprecated mysql_* with mysqli_* in upgrade scripts #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Frankli9986 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace deprecated mysql_* with mysqli_* in upgrade scripts #771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/install/Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ public static function get()
',
/* Convert dashboard component parameters to serialize()d arrays. */
'225' => 'PHP:
global $mySQLConnection;
include_once(\'./lib/ListEditor.php\');

$rs = $db->getAllAssoc(
Expand All @@ -722,7 +723,7 @@ public static function get()
"UPDATE
dashboard_component
SET
module_parameters = \'" . mysql_real_escape_string($serializedValue) . "\'
module_parameters = \'" . mysqli_real_escape_string($mySQLConnection, $serializedValue) . "\'
WHERE
dashboard_component_id = " . $row[\'dashboard_component_id\']
);
Expand Down Expand Up @@ -851,7 +852,7 @@ public static function get()
'253' => 'PHP:
$rs = $db->query(\'SELECT * FROM zipcodes\');

if ($rs && mysql_fetch_row($rs))
if ($rs && mysqli_fetch_row($rs))
{
$db->query(\'DELETE FROM zipcodes\');
$schemaZipcodes = @file_get_contents(\'db/upgrade-zipcodes.sql\');
Expand Down Expand Up @@ -1230,10 +1231,11 @@ public static function get()
UPDATE extra_field_settings SET position = extra_field_settings_id;
',
'341' => 'PHP:
global $mySQLConnection;
$lists = $db->getAllAssoc("SELECT * FROM saved_list");
foreach($lists as $list)
{
$db->query(sprintf("UPDATE saved_list SET description = \"%s\" WHERE saved_list_id = %s", mysql_real_escape_string(urldecode($list[\'description\'])), $list[\'saved_list_id\']));
$db->query(sprintf("UPDATE saved_list SET description = \"%s\" WHERE saved_list_id = %s", mysqli_real_escape_string($mySQLConnection, urldecode($list[\'description\'])), $list[\'saved_list_id\']));
}
',
'343' => '
Expand Down
Loading