Skip to content

fix formik metadata reference according to new scheme#1519

Open
ypatios wants to merge 3 commits intoopencast:r/19.xfrom
ypatios:series-acl-not-copied-in-new-event-wizard
Open

fix formik metadata reference according to new scheme#1519
ypatios wants to merge 3 commits intoopencast:r/19.xfrom
ypatios:series-acl-not-copied-in-new-event-wizard

Conversation

@ypatios
Copy link

@ypatios ypatios commented Mar 7, 2026

Fixes #1518

"In the add event wizard, if a series is selected in the metadata tab, the respective ACL is copied to the new event and it's automatically set and visible in the ACL tab. The bug consists in that the above expected behaviour is broken (the series ACL does not get copied to the event ACL).

"It is assumed that this unintended behaviour was introduced with 25b77ad"

grok.com (v4.1, Expert Mode) has helped with analysis and coding.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Hi @ypatios
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@ypatios ypatios requested a review from Arnei March 7, 2026 11:12
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1519

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1519

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ypatios ypatios marked this pull request as draft March 7, 2026 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

This pull request is deployed at test.admin-interface.opencast.org/1519/2026-03-13_06-58-15/ .
It might take a few minutes for it to become available.

@ypatios ypatios marked this pull request as ready for review March 7, 2026 14:29
@ypatios ypatios self-assigned this Mar 7, 2026
@ypatios ypatios added discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays type:bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Mar 7, 2026
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urg, my changes were supposed to make these things happen less, not more :(

Anyway, this looks reasonable, thanks for fixing! I changed to the base to r/19.x as we surely want it in there, could you rebase on that?

@Arnei Arnei changed the base branch from develop to r/19.x March 10, 2026 14:59
@ypatios ypatios force-pushed the series-acl-not-copied-in-new-event-wizard branch from cd19505 to 55fdc91 Compare March 11, 2026 17:37
@ypatios
Copy link
Author

ypatios commented Mar 11, 2026

thx @Arnei :) did the rebase; all looking clean. @gregorydlogan, the ~48 irrelevant commits gone ;)
lmk if all good for merging.

// theme: string,
metadata: {
"dublincore/episode_isPartOf": string,
// other metadata fields as needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point :) done

@ypatios ypatios requested a review from geichelberger March 13, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays good first issue Good for newcomers help wanted Extra attention is needed type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Series ACL not copied in New Event Wizard

3 participants