Fix multi-select values in metadata not removable (Safari)#1496
Fix multi-select values in metadata not removable (Safari)#1496Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Conversation
Fixes a bug where values could not be removed from multi-select fields, like presenters or contributors in the event metadata. When clicking on the "X" of the blue box with the value, the field would leave edit mode but the value was not removed. This fix has an unpleasant side effect, where multi-select fields will not properly blur anymore when left via tab navigation. I am not sure how to properly fix this with the current code.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1496/2026-01-05_11-52-27/ . |
|
This doesn't break anything obvious to me, but I don't have a Mac to test with. @mtneug @karendolan @rute-santos @snoesberger I think you're all on macs. There's a test above, don't even have to build anything. |
|
I did a quick test on my Mac using Safari. I can now successfully remove values from the multi-select fields. I also successfully tested this with Firefox and Chrome. But I had to use the docker image to test this. test.admin-interface.opencast.org/1496/2026-01-05_11-52-27/ doesn't allow me to change metadata because of CORS policy:
It would be nice if the CORS policy could be adapted to allow such tests. |
Fixes a bug where values could not be removed from multi-select fields, like presenters or contributors in the event metadata. When clicking on the "X" of the blue box with the value, the field would leave edit mode but the value was not removed. This is due to a timing issue most notable in Safari. This patch fixes the issue by making the field not leave edit mode when clicking on "X", which is how multi-select fields behaved in 18.x as well.
This fix has an unpleasant side effect, where multi-select fields will not properly blur anymore when left via tab navigation. I am not sure how to properly fix this with the current code.