Open
Conversation
carmichaelong
requested changes
Feb 21, 2026
Contributor
carmichaelong
left a comment
There was a problem hiding this comment.
Thanks @antoinefalisse, this looks like it should fix the issue that you mentioned.
One change that could be helpful is to make a small helper function for grabbing the clean device id, and then use it in the 3 places in this function (L233, L240, L259). I think the helper function would look something like this (haven't actually tested this):
def getCleanDeviceID(video):
return video["device_id"].replace('-', '').upper()
Also if you had a quick test that could check this that would be great, but given that this is a small patch to a complicated function, I'd be OK with skipping a test for now for this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iPhoneModel order should take the camera mapping into account since video order might change across trials. Luckily this should not affect processing.