Skip to content

feat(search): Implement 'never_broadcasted' filter for media search and add i… #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sreeshanth-soma wants to merge 1 commit into
base: 5.5-develop
Choose a base branch
from
Open

feat(search): Implement 'never_broadcasted' filter for media search and add i… #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion core/models/media_model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ public function search_filters_validate($args = [])
OBFHelpers::require_args($args, ['filters']);
$filters = $args['filters'];

$allowed_filters = ['comments','artist','title','album','year','type','category','country','language','genre','duration','is_copyright_owner','status','dynamic_select'];
$allowed_filters = ['comments','artist','title','album','year','type','category','country','language','genre','duration','is_copyright_owner','never_broadcasted','status','dynamic_select'];
$allowed_operators = [
// deprecated
'like',
Expand Down Expand Up @@ -1021,6 +1021,16 @@ public function search_filters_where_array($args = [])
$filter = get_object_vars($filter);
}

// never_broadcasted filter: uses subquery, skip normal column mapping
if ($filter['filter'] == 'never_broadcasted') {
if ($filter['val'] == '1') {
$where_array[] = 'NOT EXISTS (SELECT 1 FROM players_log WHERE players_log.media_id = media.id)';
} else {
$where_array[] = 'EXISTS (SELECT 1 FROM players_log WHERE players_log.media_id = media.id)';
}
continue;
}

// our possible column (mappings)
$column_array = [];
$column_array['artist'] = 'media.artist';
Expand Down
1 change: 1 addition & 0 deletions public/html/sidebar/advanced_search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<option value="is_copyright_owner" data-compare="select" data-value="bool" data-t>
Is Copyright Owner
</option>
<option value="never_broadcasted" data-compare="select" data-value="bool" data-t>Never Been Broadcast</option>
<option value="status" data-compare="select" data-value="status" data-t>Status</option>
<option value="dynamic_select" data-compare="select" data-value="bool" data-t>Include in Dynamic Selections?</option>
</select>
Expand Down
Loading