Skip to content

Remove all endpoints that had a InBrainRegionDep, but don't have a brain_region_id#501

Merged
mgeplf merged 2 commits intomainfrom
remove-within-brain-on-sims
Jan 7, 2026
Merged

Remove all endpoints that had a InBrainRegionDep, but don't have a brain_region_id#501
mgeplf merged 2 commits intomainfrom
remove-within-brain-on-sims

Conversation

@mgeplf
Copy link
Copy Markdown
Collaborator

@mgeplf mgeplf commented Jan 6, 2026

…brain_region_id

* if the model serving the endpoint doesn't have brain_region_id, this
  will result in an error; ex: #487

* Added a simplistic test to find these endpoints
* Note: this doesn't find endpoints that *should* have `InBrainRegionDep`
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/filters/brain_region.py 100.00% <ø> (ø)
app/service/analysis_notebook_execution.py 100.00% <ø> (ø)
app/service/calibration.py 100.00% <ø> (ø)
app/service/circuit_extraction_campaign.py 94.44% <ø> (ø)
app/service/circuit_extraction_config.py 94.59% <ø> (ø)
...pp/service/circuit_extraction_config_generation.py 100.00% <ø> (ø)
app/service/circuit_extraction_execution.py 100.00% <ø> (ø)
app/service/electrical_recording_stimulus.py 100.00% <ø> (ø)
app/service/external_url.py 100.00% <ø> (ø)
app/service/ion_channel_modeling_campaign.py 94.59% <ø> (ø)
... and 19 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgeplf mgeplf merged commit b6ba527 into main Jan 7, 2026
2 checks passed
@mgeplf mgeplf deleted the remove-within-brain-on-sims branch January 7, 2026 06:40
GianlucaFicarelli added a commit that referenced this pull request Jan 16, 2026
* origin/main:
  Update `brain-atlas` endpoints (#506)
  Add published_in filter in ScientificArtifact (#505)
  Make nullable attributes of EMDenseReconstructionDataset (#503)
  Remove all endpoints that had a `InBrainRegionDep`, but don't have a brain_region_id (#501)
  Add pref_label/alt_label ilike_search to ETypeClass/MTypeClass filters (#500)
  add `number_neurons` to Simulation` (#493)
  Fix incorrect returned values when getting `ascendants_and_descendants` (#498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants