OBLS-561 Streamline barcode-not-recognized recovery in Inbound Sortation#396
Open
olewandowski1 wants to merge 4 commits intodevelopfrom
Open
OBLS-561 Streamline barcode-not-recognized recovery in Inbound Sortation#396olewandowski1 wants to merge 4 commits intodevelopfrom
olewandowski1 wants to merge 4 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to streamline the Inbound Sortation recovery path when a scanned barcode is not recognized, by routing users into product lookup/details and giving them a faster path back to sortation after updating a product barcode.
Changes:
- Replaces the generic sortation failure alert with a dedicated “Barcode unrecognized” dialog in the Sortation entry flow.
- Propagates a
fromSortationnavigation flag through Products → Product Details so Product Details can show a return path back to Sortation. - Reworks the Edit Barcode modal to use
ScannerInputand adds a loading state while saving product identifiers.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/screens/Sortation/styles.ts |
Adds styles for the new barcode-unrecognized dialog UI. |
src/screens/Sortation/SortationEntryScreen.tsx |
Replaces the old error alert with the new dialog and adds navigation into Products. |
src/screens/Sortation/BarcodeUnrecognizedDialog.tsx |
Introduces the new modal dialog for unrecognized barcode handling. |
src/screens/Products/types.ts |
Extends Products screen props to include route access. |
src/screens/Products/index.tsx |
Threads the sortation-origin flag into all Product Details navigation paths. |
src/screens/ProductDetails/styles.ts |
Adds styles for the return-to-sortation banner and modal button layout. |
src/screens/ProductDetails/index.tsx |
Shows the sortation return banner and adjusts barcode save handling. |
src/screens/ProductDetails/EditBarcodeModal.tsx |
Replaces the text input with ScannerInput in the barcode edit modal. |
src/redux/sagas/products.ts |
Adds full-screen loading around product identifier updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openboxes.atlassian.net/browse/OBLS-561
Changes:
Barcode unrecognizeddialog that links to the Products list, letting the user assign the scanned barcode to an existing product without leaving the flow via the Dashboard.fromSortationnav param through Products → ProductDetails so aBACK TO SORTATIONbtn appears on the Product Details screen for a one-tap return after the barcode is saved.ScannerInput.Kazam_screencast_00066.mp4