Feature multi locale#586
Draft
MajeurAndroid wants to merge 19 commits intomasterfrom
Draft
Conversation
revert switch between main and secondary locale tune suggestion weights for each locale based on mConfidence more preparations for making secondary dictionary selectable isValidSpellingWord now uses both dictionaries (called only by spell checker)
Add multilingual typing
Fix crash when getting available dictionaries
Update feature-multi-locale
Contributor
|
When restarting my phone, I get the following crash: The crash does not happen on my test phone, or if I have secondary locale set to none (secondary dictionary is loaded in DictionaryFacilitatorImpl.java:426). I don't really understand what is going on, as |
|
Sounds like there's some new code that isn't compatible with Direct Boot. See this PR: #346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.