Use DockerParser from updated spython 0.0.73#4
Open
stain wants to merge 1 commit intoopenbases:masterfrom
Open
Use DockerParser from updated spython 0.0.73#4stain wants to merge 1 commit intoopenbases:masterfrom
stain wants to merge 1 commit intoopenbases:masterfrom
Conversation
Member
|
So sorry that I didn't see this! I'm literally going down emails from top to bottom, and this was toward the bottom. Take a look at #5 and we can add some of the nice changes you've done here that aren't present there after review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3
btw, it seems to time out, so
manifest = json.loads(response['message'])[0]is not executed inContainerRecipe/extract.py- just moved it into the if block to avoid errors.