Allow network access for package-installing workflow turns#65
Open
andrew749 wants to merge 1 commit into
Open
Conversation
Summary: - Enable network access for the default Symphony turn sandbox policy used by the checked-in workflow. - Document that workflows running package managers or external host resolution need the networkAccess turn sandbox setting. Rationale: - The brix oaipkg install failure maps to Symphony launching Codex turns without an explicit network allowance, so DNS-dependent package installs can fail inside the turn sandbox. - Keeping the change in WORKFLOW.md is the smallest durable fix for this orchestration path and avoids changing safer implementation defaults for other workflows. Tests: - /usr/bin/env mix run -e IO.inspect(SymphonyElixir.Config.codex_runtime_settings(...)) - /usr/bin/env mix specs.check - /usr/bin/env mix test test/symphony_elixir/workspace_and_config_test.exs - /usr/bin/env make all MIX="/usr/bin/env mix" Co-authored-by: Codex <codex@openai.com>
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Brix oaipkg installs in Symphony-launched FSS runs need DNS/network access, but the workflow turn sandbox did not enable it.
TL;DR
Allow Symphony workflow turns to use network/DNS for package installs.
Summary
networkAccess: trueto the workflow turn sandbox policy.Alternatives
Test Plan
/usr/bin/env mix run -e IO.inspect(...)before and after config change/usr/bin/env mix specs.check/usr/bin/env mix test test/symphony_elixir/workspace_and_config_test.exs/usr/bin/env make all MIX="/usr/bin/env mix"