Skip to content

fix(parsing): drop TextFormatT parameterization in parse_response to fix memory leak (#3084) #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MukundaKatta wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix(parsing): drop TextFormatT parameterization in parse_response to fix memory leak (#3084) #3088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/openai/lib/_parsing/_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ def parse_response(

content_list.append(
construct_type_unchecked(
type_=ParsedResponseOutputText[TextFormatT],
# Drop the TextFormatT parameterization: pydantic cannot resolve a free
# TypeVar so model_rebuild() always returns False, which means
# MockCoreSchema._built_memo is never populated and a new Rust-backed
# SchemaValidator is allocated on every call. See issue #3084.
type_=ParsedResponseOutputText,
value={
**item.to_dict(),
"parsed": parse_text(item.text, text_format=text_format),
Expand All @@ -78,7 +82,8 @@ def parse_response(

output_list.append(
construct_type_unchecked(
type_=ParsedResponseOutputMessage[TextFormatT],
# See note above: non-parameterized generic keeps the schema cache hot.
type_=ParsedResponseOutputMessage,
value={
**output.to_dict(),
"content": content_list,
Expand Down Expand Up @@ -130,7 +135,10 @@ def parse_response(
output_list.append(output)

return construct_type_unchecked(
type_=ParsedResponse[TextFormatT],
# See note above: non-parameterized generic keeps the schema cache hot.
# At runtime Python's generics are erased, so the constructed object's type
# is identical either way — only the pydantic schema rebuild path differs.
type_=ParsedResponse,
value={
**response.to_dict(),
"output": output_list,
Expand Down