-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: strip stale reasoning item IDs from local session history #3582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oxygen56
wants to merge
1
commit into
openai:main
Choose a base branch
from
Oxygen56:fix/stale-reasoning-item-ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| """Tests for stripping stale reasoning item IDs from local session history.""" | ||
| from __future__ import annotations | ||
|
|
||
| from agents.run_internal.items import strip_stale_reasoning_item_ids | ||
|
|
||
|
|
||
| class TestStripStaleReasoningItemIds: | ||
| def test_strips_id_from_reasoning_item(self) -> None: | ||
| items: list[dict[str, object]] = [ | ||
| {"type": "reasoning", "id": "rs_deadbeef", "summary": []}, | ||
| ] | ||
| result = strip_stale_reasoning_item_ids(items) # type: ignore[arg-type] | ||
| assert result[0].get("id") is None # type: ignore[union-attr] | ||
|
|
||
| def test_preserves_non_reasoning_item_ids(self) -> None: | ||
| items: list[dict[str, object]] = [ | ||
| {"type": "message", "id": "msg_123", "role": "user", "content": "hi"}, | ||
| {"type": "function_call", "id": "fc_456", "call_id": "c1", "name": "f", "arguments": "{}"}, | ||
| ] | ||
| result = strip_stale_reasoning_item_ids(items) # type: ignore[arg-type] | ||
| assert result[0].get("id") == "msg_123" # type: ignore[union-attr] | ||
| assert result[1].get("id") == "fc_456" # type: ignore[union-attr] | ||
|
|
||
| def test_reasoning_without_id_passes_through(self) -> None: | ||
| items: list[dict[str, object]] = [ | ||
| {"type": "reasoning", "summary": []}, | ||
| ] | ||
| result = strip_stale_reasoning_item_ids(items) # type: ignore[arg-type] | ||
| assert "id" not in result[0] # type: ignore[arg-type] | ||
|
|
||
| def test_mixed_items_strip_only_reasoning(self) -> None: | ||
| items: list[dict[str, object]] = [ | ||
| {"type": "reasoning", "id": "rs_1", "summary": []}, | ||
| {"type": "message", "id": "msg_1", "role": "assistant", "content": "ok"}, | ||
| {"type": "reasoning", "id": "rs_2", "summary": []}, | ||
| {"type": "function_call_output", "call_id": "c1", "output": "result"}, | ||
| ] | ||
| result = strip_stale_reasoning_item_ids(items) # type: ignore[arg-type] | ||
| assert result[0].get("id") is None # type: ignore[union-attr] | ||
| assert result[1].get("id") == "msg_1" # type: ignore[union-attr] | ||
| assert result[2].get("id") is None # type: ignore[union-attr] | ||
| assert result[3].get("call_id") == "c1" # type: ignore[union-attr] | ||
|
|
||
| def test_empty_list(self) -> None: | ||
| result = strip_stale_reasoning_item_ids([]) | ||
| assert result == [] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a caller uses a local
sessionwithRunConfig(reasoning_item_id_policy="preserve"), this unconditional strip runs before the config is consulted, so persisted reasoning items are sent without their IDs even though the public policy says"preserve"keeps IDs. This makes local session behavior inconsistent with generated same-run history and prevents callers who explicitly need ID preservation from opting out; pass the resolved policy into session preparation or only apply this mitigation when preservation was not requested.Useful? React with 👍 / 👎.