Skip to content

fix: expose sandbox error retryability#3581

Merged
qiyaoq-oai merged 2 commits into
mainfrom
dev/qiyaoq/sandbox-error-retryability
Jun 5, 2026
Merged

fix: expose sandbox error retryability#3581
qiyaoq-oai merged 2 commits into
mainfrom
dev/qiyaoq/sandbox-error-retryability

Conversation

@qiyaoq-oai
Copy link
Copy Markdown
Contributor

@qiyaoq-oai qiyaoq-oai commented Jun 5, 2026

Context: temporalio/sdk-python#1548

This pull request adds provider-neutral retryability metadata for sandbox failures.

  • Adds SandboxError.retryable with True, False, and None for unknown classification.
  • Propagates retryability through wrapped sandbox errors.
  • Emits retryability in sandbox finish events and trace error payloads.
  • Classifies clear terminal/transient cases across sandbox providers without exposing provider internals to integrations.
  • Adds focused tests for core error behavior, provider classifiers, and observability.

@qiyaoq-oai qiyaoq-oai marked this pull request as ready for review June 5, 2026 00:42
@qiyaoq-oai qiyaoq-oai requested review from sdcoffey and seratch June 5, 2026 00:42
@qiyaoq-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9485f03a53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/extensions/sandbox/modal/sandbox.py Outdated
@seratch seratch changed the title Expose sandbox error retryability fix: expose sandbox error retryability Jun 5, 2026
Copy link
Copy Markdown
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking integration note for the Temporal follow-up: it would be safer to treat only retryable is False as an explicit non-retryable signal, while preserving the orchestrator's existing policy for True and None. In particular, True should not be interpreted as a blanket guarantee that replaying an arbitrary exec is side-effect safe.

@qiyaoq-oai qiyaoq-oai merged commit 8eaa4b9 into main Jun 5, 2026
9 checks passed
@qiyaoq-oai qiyaoq-oai deleted the dev/qiyaoq/sandbox-error-retryability branch June 5, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants