fix: expose sandbox error retryability#3581
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9485f03a53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
left a comment
There was a problem hiding this comment.
One non-blocking integration note for the Temporal follow-up: it would be safer to treat only retryable is False as an explicit non-retryable signal, while preserving the orchestrator's existing policy for True and None. In particular, True should not be interpreted as a blanket guarantee that replaying an arbitrary exec is side-effect safe.
Context: temporalio/sdk-python#1548
This pull request adds provider-neutral retryability metadata for sandbox failures.
SandboxError.retryablewithTrue,False, andNonefor unknown classification.