Open
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Let's tighten up the copy then will be good to go
| /// ARC escalations. Defaults to `user`. `guardian_subagent` uses a carefully | ||
| /// prompted subagent to gather relevant context and apply a risk-based | ||
| /// ARC escalations. Defaults to `user`. `guardian_subagent` uses the | ||
| /// auto-reviewer subagent to gather relevant context and apply a risk-based |
Collaborator
There was a problem hiding this comment.
I think we should keep this language
| assert_eq!( | ||
| stage.experimental_menu_description().map(str::to_owned), | ||
| Some( | ||
| "When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to a carefully-prompted security reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.".to_string() | ||
| "When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to the auto-reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.".to_string() |
Collaborator
There was a problem hiding this comment.
update here as well
| name: "Guardian Approvals", | ||
| menu_description: "When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to a carefully-prompted security reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.", | ||
| name: "Auto-Review", | ||
| menu_description: "When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to the auto-reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.", |
| @@ -477,8 +477,8 @@ async fn permissions_selection_marks_guardian_approvals_current_after_session_co | |||
| let popup = render_bottom_popup(&chat, /*width*/ 120); | |||
|
|
|||
| assert!( | |||
| popup.contains("Guardian Approvals (current)"), | |||
| "expected Guardian Approvals to be current after SessionConfigured sync: {popup}" | |||
| popup.contains("Auto-Review (current)"), | |||
Collaborator
There was a problem hiding this comment.
Sentence-case here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a user-facing change for our rebranding of guardian to auto-review.