Skip to content

[codex] tighten shell wrapper detection#18001

Draft
viyatb-oai wants to merge 2 commits intomainfrom
codex/viyatb/sandbox-hardening-shell-trust
Draft

[codex] tighten shell wrapper detection#18001
viyatb-oai wants to merge 2 commits intomainfrom
codex/viyatb/sandbox-hardening-shell-trust

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented Apr 15, 2026

Summary:

  • Tighten shell wrapper recognition to exact known shells.
  • Reuse shared shell wrapper detection for display and approval matching.
  • Keep unrecognized shell-like paths visible in command display and approval matching.

Validation:

  • just fmt
  • cargo test -p codex-shell-command
  • No additional tests run after PR-open request.

viyatb-oai and others added 2 commits April 15, 2026 14:04
Use exact matches for known shell wrappers so command display and approval keys do not treat arbitrary shell-like paths as trusted wrappers.

Co-authored-by: Codex <noreply@openai.com>
Expose the known-shell detector from codex-shell-command and map it into codex-core's runtime shell type.

Co-authored-by: Codex <noreply@openai.com>
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/sandbox-hardening-shell-trust branch from 2a17549 to 2bd0700 Compare April 15, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant