[codex] Make command exec delta tests chunk tolerant#17999
Merged
euroelessar merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
pakrym-oai
reviewed
Apr 15, 2026
| assert!(delta.cap_reached); | ||
| let deadline = Instant::now() + DEFAULT_READ_TIMEOUT; | ||
| let mut stdout = String::new(); | ||
| loop { |
Collaborator
There was a problem hiding this comment.
didn't we add a mehtod below do to just this?
Collaborator
Author
There was a problem hiding this comment.
they are slightly different, but let me think a bit more
pakrym-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The command/exec protocol exposes output as deltas, so tests should not rely on chunk boundaries being stable. A line like
out-start\nmay arrive split across multiple notifications, and stdout/stderr notifications may interleave.Validation
just fmtgit diff --checkcargo test -p codex-app-server suite::v2::command_exec