Open
Conversation
jeffsharris
force-pushed
the
codex/bazel-skip-manual-tests
branch
from
1f21c17 to
96661a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Bazel workflow currently runs
bazel test //...with--test_tag_filters=-argument-comment-lint. In practice,tests(//...)includes internal raw Rust*-unit-tests-bintargets generated bycodex_rust_crate, even though those targets are taggedmanualand have correspondingworkspace_root_testwrapper targets.Those raw binaries bypass the wrapper environment/runfiles setup. For example,
//codex-rs/core:core-unit-tests-bincan failshell_snapshot::tests::macos_zsh_snapshot_includes_sections, while the intended//codex-rs/core:core-unit-testswrapper passes the same test.This adds
-manualto the Bazel test tag filter so CI exercises the intended wrapper/integration test targets and does not run internal manual test binaries directly.Validation
bazel test //codex-rs/core:core-unit-tests --test_arg=macos_zsh_snapshot_includes_sections --test_output=errorspasses locally.bazel test //codex-rs/core:core-unit-tests-bin --test_arg=macos_zsh_snapshot_includes_sections --test_output=errorsreproduces the raw-bin failure locally.bazel query 'attr(tags, manual, //codex-rs/core:*)'shows//codex-rs/core:core-unit-tests-binis taggedmanual.bazel test //codex-rs/core:core-unit-tests-bin --test_tag_filters=-manual --test_output=errorsreports the explicit target is excluded by filters, confirming the tag filter applies.