Skip to content

Fix flaky app list tests#17975

Open
mzeng-openai wants to merge 1 commit intomainfrom
dev/mzeng/fix-flaky-app-list-tests
Open

Fix flaky app list tests#17975
mzeng-openai wants to merge 1 commit intomainfrom
dev/mzeng/fix-flaky-app-list-tests

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

Summary

  • Abort unfinished app-list refresh tasks on error or timeout so a failed request cannot leave background work mutating caches later.
  • Make the disabled-connectors test explicitly write connectors = false into the temp config.
  • Strengthen the force-refetch cache test to exercise the race window that was causing intermittent failures.

Testing

  • just fmt
  • cargo test -p codex-app-server suite::v2::app_list
  • cargo test -p codex-app-server

@mzeng-openai mzeng-openai marked this pull request as ready for review April 15, 2026 19:30
.await??;
assert!(refetch_error.error.message.contains("failed to"));

tokio::time::sleep(Duration::from_millis(250)).await;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't sounds deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants