[codex] Split app-server integration tests into shards#17973
Draft
starr-openai wants to merge 7 commits intomainfrom
Draft
[codex] Split app-server integration tests into shards#17973starr-openai wants to merge 7 commits intomainfrom
starr-openai wants to merge 7 commits intomainfrom
Conversation
Replace the single all.rs integration root with smaller roots grouped by area so Bazel and CI can schedule them as independent app-server test targets. Co-authored-by: Codex <noreply@openai.com>
starr-openai
force-pushed
the
starr/app-server-test-shards
branch
from
3145f87 to
de0e824
Compare
Windows test actions run locally in CI, and several Rust integration test binaries spawn subprocesses or servers. Limit local test-process fanout so sharded tests contend less on the runner while preserving the broader Bazel job count for scheduling and cache/download work. Co-authored-by: Codex <noreply@openai.com>
Replace the one-second sleep in the unsubscribe-during-turn test with a sentinel-file command so the test unsubscribes while command execution is definitely still running. Also use Bazel's printed FAIL test.log path when tailing failed CI logs, which fixes Windows MSVC output-path mismatches. Co-authored-by: Codex <noreply@openai.com>
Replace shell-command blocking in the unsubscribe-during-turn test with a gated streaming SSE response. This keeps the turn in progress without filesystem polling, shell sleeps, or Windows path translation. Add a request-count notification helper to the streaming SSE test server so tests can wait for the model request deterministically. Co-authored-by: Codex <noreply@openai.com>
Remove stale imports and the unused response-count stabilization helper after switching the unsubscribe test to gated streaming SSE. Add the required argument comment for the request-count literal. Co-authored-by: Codex <noreply@openai.com>
macOS Bazel CI runs build actions remotely but test actions locally. After splitting app-server tests into separate binaries, cap local test-process fanout on macOS as well so server-spawning integration tests do not contend heavily on the runner. Co-authored-by: Codex <noreply@openai.com>
Limit Windows CI to one Rust test thread per test binary so the split app-server shards do not multiply child-process-heavy test concurrency on the runner. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super::...imports still workall.rsand suite aggregator modulesValidation
Expected CI impact
//codex-rs/app-server:app-server-all-testwith independent targets generated from the newtests/*.rsroots