Skip to content

Add use_agent_identity feature flag#17385

Merged
adrian-openai merged 5 commits intomainfrom
dev/adrian/codex/agent-identity-flag
Apr 11, 2026
Merged

Add use_agent_identity feature flag#17385
adrian-openai merged 5 commits intomainfrom
dev/adrian/codex/agent-identity-flag

Conversation

@adrian-openai
Copy link
Copy Markdown
Contributor

@adrian-openai adrian-openai commented Apr 10, 2026

Summary

Stack PR 1 of 4 for feature-gated agent identity support.

This PR adds the under-development features.use_agent_identity config flag and schema plumbing only. Runtime behavior remains unchanged with the flag off.

Stack

Validation

Covered as part of the local stack validation pass:

  • just fmt
  • cargo test -p codex-core --lib agent_identity
  • cargo test -p codex-core --lib agent_assertion
  • cargo test -p codex-core --lib websocket_agent_task
  • cargo test -p codex-api api_bridge
  • cargo build -p codex-cli --bin codex

Notes

The full local app-server E2E path is still being debugged after PR creation. The current branch stack is directionally ready for review while that follow-up continues.

@adrian-openai
Copy link
Copy Markdown
Contributor Author

For continuity, this replaces the previous closed draft stack:

I tried reopening the original PRs first, but GitHub reported they were not reopenable (viewerCanReopen=false / reopenPullRequest failed), so this new stack is the active review path.

@adrian-openai adrian-openai marked this pull request as ready for review April 10, 2026 22:56
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 677dedea05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


#[test]
fn image_detail_original_feature_is_under_development() {
assert_eq!(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix ImageDetailOriginal stage assertion

The added image_detail_original_feature_is_under_development test asserts Feature::ImageDetailOriginal.stage() == Stage::UnderDevelopment, but FEATURES defines ImageDetailOriginal as Stage::Experimental. This makes cargo test -p codex-features fail and can block CI on unrelated work.

Useful? React with 👍 / 👎.

@adrian-openai adrian-openai force-pushed the dev/adrian/codex/agent-identity-flag branch from 636678c to 87397ee Compare April 11, 2026 06:43
@adrian-openai adrian-openai merged commit 39cc853 into main Apr 11, 2026
29 of 30 checks passed
@adrian-openai adrian-openai deleted the dev/adrian/codex/agent-identity-flag branch April 11, 2026 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants