Add use_agent_identity feature flag#17385
Conversation
|
For continuity, this replaces the previous closed draft stack:
I tried reopening the original PRs first, but GitHub reported they were not reopenable ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 677dedea05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #[test] | ||
| fn image_detail_original_feature_is_under_development() { | ||
| assert_eq!( |
There was a problem hiding this comment.
Fix ImageDetailOriginal stage assertion
The added image_detail_original_feature_is_under_development test asserts Feature::ImageDetailOriginal.stage() == Stage::UnderDevelopment, but FEATURES defines ImageDetailOriginal as Stage::Experimental. This makes cargo test -p codex-features fail and can block CI on unrelated work.
Useful? React with 👍 / 👎.
d58ac15 to
9bbc1e8
Compare
6a1a18b to
636678c
Compare
# Conflicts: # codex-rs/features/src/tests.rs
636678c to
87397ee
Compare
Summary
Stack PR 1 of 4 for feature-gated agent identity support.
This PR adds the under-development
features.use_agent_identityconfig flag and schema plumbing only. Runtime behavior remains unchanged with the flag off.Stack
AgentAssertiondownstream when enabledValidation
Covered as part of the local stack validation pass:
just fmtcargo test -p codex-core --lib agent_identitycargo test -p codex-core --lib agent_assertioncargo test -p codex-core --lib websocket_agent_taskcargo test -p codex-api api_bridgecargo build -p codex-cli --bin codexNotes
The full local app-server E2E path is still being debugged after PR creation. The current branch stack is directionally ready for review while that follow-up continues.