Fix Docker build and test hash for Shapely upgrade#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shapely == 2.0.1to>= 2.0.1, < 3— the pinned version has no pre-built wheel for Alpine/musl and fails to build due to missingpkg_resources(same fix as Make Docker build work again #91)protobufpin from== 5.29.6to>= 4.21, < 5— the 5.x version conflicts withmapbox-vector-tile 2.0.1which requiresprotobuf < 5(same fix as Make Docker build work again #91)test_single_ny_orange— the newer Shapely wheel bundles a different GEOS version which produces slightly different WKT for high-precision coordinates, changing the deterministic hashFixes #90, fixes #92
Supersedes #91 (includes the same setup.py fixes plus the test fix)
Test plan
docker build --no-cache -t batch-machine .completes successfullypython3 -m unittest openaddr.tests.TestOA🤖 Generated with Claude Code