Skip to content

feat: add Accept header for integration tests #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
civsiv wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add Accept header for integration tests #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a51794
feat: add Accept header for integration tests
civsiv Apr 2, 2025
ce90242
quote marks
civsiv Apr 2, 2025
64c5f8d
more changes
civsiv Apr 3, 2025
8a30095
fix typo
civsiv Apr 17, 2025
e0ea6f1
Merge branch 'master' into feature/fix-accept-and-content-headers
civsiv Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/openactive-broker-microservice/src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ async function renderTemplate(templateName, data) {
*/
function withOpportunityRpdeHeaders(getHeadersFn) {
return async () => ({
Accept: 'application/json, application/vnd.openactive.booking+json; version=1',
Accept: 'application/vnd.openactive.booking+json; version=1',
'Cache-Control': 'max-age=0',
...await getHeadersFn() || {},
});
Expand Down
2 changes: 1 addition & 1 deletion packages/openactive-broker-microservice/src/util/request-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function getOrdersFeedHeader(bookingPartnerIdentifier) {
*/
function withOrdersRpdeHeaders(getHeadersFn) {
return async () => ({
Accept: 'application/json, application/vnd.openactive.booking+json; version=1',
Accept: 'application/vnd.openactive.booking+json; version=1',
'Cache-Control': 'max-age=0',
...await getHeadersFn() || {},
});
Expand Down
3 changes: 3 additions & 0 deletions packages/openactive-integration-tests/test/global-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ async function getEndpointUrl() {
async function deleteTestDataset(testInterfaceBaseUrl) {
const response = await axios.delete(`${testInterfaceBaseUrl}/test-interface/datasets/${TEST_DATASET_IDENTIFIER}`,
{
headers: {
'Accept': 'application/vnd.openactive.booking+json; version=1',
},
timeout: 60000,
});

Expand Down
1 change: 1 addition & 0 deletions packages/openactive-integration-tests/test/helpers/request-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ class RequestHelper {

createHeaders() {
return {
Accept: 'application/vnd.openactive.booking+json; version=1',
'Content-Type': 'application/vnd.openactive.booking+json; version=1',
Copy link
Copy Markdown
Contributor Author

@civsiv civsiv Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to say what the content type of the request is

...this._getSellerRequestHeaders(),
};
Expand Down
Loading