-
Notifications
You must be signed in to change notification settings - Fork 54
Bump toml11 to 4.4.0, nlohmann_json to 3.12.0 #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
cd56ff7 to
088c8c9
Compare
This reverts commit bc1817d.
Pybind's variant handling explodes MSVC, so we do it instead.
|
Pybind11 3.0.1 seems to explode MSVC: It looks like these troubles are caused by I think that the following workaround could fix it, by never exposing the "get_attribute",
[](Attributable &attr, std::string const &key) {
auto v = attr.getAttribute(key);
- return v.getVariant<attribute_types>();
+ return std::visit(
+ [](auto const &val) { return py::cast(val); },
+ v.getVariant<attribute_types>());
// TODO instead of returning lists, return all arrays (ndim > 0)
// as numpy arrays?
}) |
|
Ok, the above workaround did help, however pybind11 still crashes MSVC: Upgrading toml11 and nlohmann_json is more pressing due to the CMake issues, I will bother with the pybind stuff later. |
Ref. pybind/pybind11#5968 |
See also #1839
Updating toml11 and nlohmann_json is needed for CMake 4