Payment gateway core functionality by conradsp · Pull Request #1 · openMF/payment-gateway

conradsp · 2018-10-02T20:05:17Z

No description provided.

…om/conradsp/payment-gateway into payment-gateway-core-functionality

…om/openMF/payment-gateway into payment-gateway-core-functionality

…yment with Beyonic. Complete Fineract integration.

ippezshelby · 2019-04-25T17:10:15Z

@conradsp , @rahulg963 Database migration scripts not found in the resource folder hence getting following errors

Table 'payment-gateway.vendor' doesn't exist
Table 'payment-gateway.transaction_data' doesn't exist

Am trying to test it but can not proceed

conradsp · 2019-04-25T17:17:04Z

Hi Robert - Could you let me know what codebase you are working from? It sounds like you have some code that has been deprecated. Thanks, Steve

…

On Thu, Apr 25, 2019 at 12:10 PM Ippez Robert ***@***.***> wrote: @conradsp <https://github.com/conradsp> , @rahulg963 <https://github.com/rahulg963> Database migration scripts not found in the resource folder hence getting following errors 1. Table 'payment-gateway.vendor' doesn't exist 2. Table 'payment-gateway.transaction_data' doesn't exist Am trying to test it but can not proceed — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFMBLWGLKK77YSR5JBSSHV3PSHQXRANCNFSM4FYTC3CA> .

ippezshelby · 2019-04-25T17:19:24Z

Am trying to test from this repo https://github.com/conradsp/payment-gateway/tree/payment-gateway-core-functionality

conradsp · 2019-04-25T17:24:35Z

My apologies - the changes to the confluence document did not get published. The repo that you are looking at is no longer current - you can find the payment hub code at: https://github.com/openMF/payment-hub I have published the changes to the Mojaloop document so that it reflects the latest changes. Thanks, Steve

…

On Thu, Apr 25, 2019 at 12:19 PM Ippez Robert ***@***.***> wrote: Am trying to test from this repo https://github.com/conradsp/payment-gateway/tree/payment-gateway-core-functionality — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFMBLWFAMHODZ4PL7HZYRFTPSHRZ3ANCNFSM4FYTC3CA> .

ippezshelby · 2019-04-25T17:31:09Z

What is the difference between these two repos? https://github.com/openMF/payment-gateway and https://github.com/openMF/payment-hub. Are they the same, if so then one should be deleted not to be confusing. Thanks

conradsp · 2019-04-25T17:34:06Z

The payment gateway repo was the first pilot implementation. The payment hub is the next generation. The payment gateway code was never pushed to openMF - it was developed on my github.

…

On Thu, Apr 25, 2019 at 12:31 PM Ippez Robert ***@***.***> wrote: What is the difference between these two repos? https://github.com/openMF/payment-gateway and https://github.com/openMF/payment-hub. Are they the same, if so then one should be deleted not to be confusing. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFMBLWFNO4U6P3JKWT4CQHLPSHTF5ANCNFSM4FYTC3CA> .

ippezshelby · 2019-04-25T17:38:51Z

Okay so we use use the payment-hub repo for testing. Could you please update the README to include how to build and deploy it.

conradsp · 2019-04-25T17:40:36Z

@marta - could you update the payment hub repo with more detailed instructions on how to build and deploy?

…

On Thu, Apr 25, 2019 at 12:38 PM Ippez Robert ***@***.***> wrote: Okay so we use use the payment-hub repo for testing. Could you please update the README to include how to build and deploy it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFMBLWAPASO43NXHC325I6DPSHUCZANCNFSM4FYTC3CA> .

rahulg963 · 2019-04-25T18:02:56Z

Hi Steve,
I really appreciate your efforts of doing the code refactoring.

marta · 2019-04-25T18:06:16Z

@conradsp No, I could not. BTW I think you meant to @ someone else.

rahulg963 · 2019-04-25T18:04:58Z

src/main/java/org/apache/payment/gateway/activeMQ/service/InboundMessageHandler.java

+        Vendor vendor = vendorRepository.getVendorById(msgObj.getPaymentChannelId());
+
+        switch (vendor.getVendorName().toLowerCase()) {
+            case "beyonic":


We can create an Enum class containing all the vendor names at a single place.

rahulg963 · 2019-04-25T18:07:31Z

src/main/java/org/apache/payment/gateway/dto/beyonic/request/WebHook.java

+
+    private String description;
+
+    private String callback_url;


We can use either snake casing or camel casing,

rahulg963 · 2019-04-25T18:08:46Z

src/main/resources/application.properties

 spring.datasource.url = jdbc:mysql://localhost:3306/payment-gateway
 spring.datasource.username = root
 spring.datasource.password = mysql
-spring.jpa.hibernate.ddl-auto = update


we can set this value to validate.

ippezshelby · 2019-04-26T11:42:19Z

@conradsp , i want to take up the task of updating the README for building the payment-hub.
when i run "mvn clean install" from the sources directory, it downloads the dependency files but fails at some point with the error below:-
_

PS D:\Projects\Incubations\payment-hub\sources> mvn clean install
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] parent
[INFO] payment-hub
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building parent 1.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ parent ---
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ parent ---
[INFO] Installing D:\Projects\Incubations\payment-hub\sources\pom.xml to C:\Users\Swift3 Technologies.m2\repository\hu\dpc\paymenthub\parent\1.0.0-SNAPSHOT\parent-1.0.0-SNAPSHOT.pom
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building payment-hub 1.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] The POM for com.interop.ilp.conditions:interop-ilp-conditions:jar:1.3 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] parent ............................................. SUCCESS [ 0.509 s]
[INFO] payment-hub ........................................ FAILURE [ 1.766 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.681 s
[INFO] Finished at: 2019-04-26T14:39:28+03:00
[INFO] Final Memory: 25M/224M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project payment-hub: Could not resolve dependencies for project hu.dpc.paymenthub:payment-hub:jar:1.0.0-SNAPSHOT: Failure to find com.interop.ilp.conditions:interop-ilp-conditions:jar:1.3 in https://mymavenrepo.com/repo/7l0NBzlPJ5KFILqnwWhy/ was cached in the local repository, resolution will not be reattempted until the update interval of camel-custom-snapshots has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :payment-hub
PS D:\Projects\Incubations\payment-hub\sources>

_

conradsp · 2019-04-26T14:00:10Z

Thanks for your work on this Robert. I updated the README with some additional build instructions. It requires some additional Maven dependencies. Let me know if the instructions work for you.

…

On Fri, Apr 26, 2019 at 6:42 AM Ippez Robert ***@***.***> wrote: @conradsp <https://github.com/conradsp> , i want to take up the task of updating the README for building the payment-hub. when i run "mvn clean install" from the sources directory, it downloads the dependency files but fails at some point with the error below:- _ PS D:\Projects\Incubations\payment-hub\sources> mvn clean install [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] Reactor Build Order: [INFO] [INFO] parent [INFO] payment-hub [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building parent 1.0.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ parent --- [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ parent --- [INFO] Installing D:\Projects\Incubations\payment-hub\sources\pom.xml to C:\Users\Swift3 Technologies.m2\repository\hu\dpc\paymenthub\parent\1.0.0-SNAPSHOT\parent-1.0.0-SNAPSHOT.pom [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building payment-hub 1.0.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for com.interop.ilp.conditions:interop-ilp-conditions:jar:1.3 is missing, no dependency information available [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] parent ............................................. SUCCESS [ 0.509 s] [INFO] payment-hub ........................................ FAILURE [ 1.766 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2.681 s [INFO] Finished at: 2019-04-26T14:39:28+03:00 [INFO] Final Memory: 25M/224M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal on project payment-hub: Could not resolve dependencies for project hu.dpc.paymenthub:payment-hub:jar:1.0.0-SNAPSHOT: Failure to find com.interop.ilp.conditions:interop-ilp-conditions:jar:1.3 in https://mymavenrepo.com/repo/7l0NBzlPJ5KFILqnwWhy/ was cached in the local repository, resolution will not be reattempted until the update interval of camel-custom-snapshots has elapsed or updates are forced -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :payment-hub PS D:\Projects\Incubations\payment-hub\sources> _ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFMBLWAM3S4C42W5B2UWOCDPSLTBZANCNFSM4FYTC3CA> .

ippezshelby · 2019-04-26T18:28:56Z

@conradsp , it worked well, thanks. Can't we eliminate CONDITIONS EVALUATION REPORT
where there are lots of Positive matches , Negative matches, Exclusions, Unconditional classes lists when running? From here how do i test the program?

Thanks
Regards

ippezshelby · 2019-04-26T18:46:23Z

@conradsp Just quickly, are we going to merge all the work done for Payment Gateway into the Payment Hub since it has a use cases already done like Beyonic integration implemented already. I think @edcable we need a webinar session to clear some confussion some of us may already be in. We seem to be having some projects within OpenMF repo with similar functionalities.
If i can mention afew:-

Payment Gateway and Payment Hub
Mobile Wallet, PiexiePay and Mifos Mobile

Thanks

edcable and others added 10 commits June 25, 2018 08:28

Initial commit

da9049d

Merge branch 'master' of https://github.com/openMF/payment-gateway

0672f3a

Merge branch 'payment-gateway-core-functionality' of https://github.c…

e2975b4

…om/conradsp/payment-gateway into payment-gateway-core-functionality

Merge branch 'payment-gateway-core-functionality' of https://github.c…

53f2c73

…om/openMF/payment-gateway into payment-gateway-core-functionality

Merge branch 'payment-gateway-core-functionality' of https://github.c…

451c9cf

…om/openMF/payment-gateway into payment-gateway-core-functionality

Merge branch 'payment-gateway-core-functionality' of https://github.c…

574741e

…om/openMF/payment-gateway into payment-gateway-core-functionality

Merge branch 'payment-gateway-core-functionality' of https://github.c…

80204c8

…om/openMF/payment-gateway into payment-gateway-core-functionality

Merge branch 'payment-gateway-core-functionality' of https://github.c…

7ef93cd

…om/openMF/payment-gateway into payment-gateway-core-functionality

Refactoring, implement ActiveMQ, implement loanDisburse and loan Repa…

2aaacdc

…yment with Beyonic. Complete Fineract integration.

Remove unused dependency - javafx.

1dc4c44

rahulg963 requested a review from Sanyam96 April 25, 2019 18:01

rahulg963 reviewed Apr 25, 2019

View reviewed changes

Conversation

conradsp commented Oct 2, 2018

Uh oh!

ippezshelby commented Apr 25, 2019

Uh oh!

conradsp commented Apr 25, 2019 via email

Uh oh!

ippezshelby commented Apr 25, 2019

Uh oh!

conradsp commented Apr 25, 2019 via email

Uh oh!

ippezshelby commented Apr 25, 2019

Uh oh!

conradsp commented Apr 25, 2019 via email

Uh oh!

ippezshelby commented Apr 25, 2019

Uh oh!

conradsp commented Apr 25, 2019 via email

Uh oh!

rahulg963 commented Apr 25, 2019

Uh oh!

marta commented Apr 25, 2019

Uh oh!

rahulg963 Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

rahulg963 Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

rahulg963 Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ippezshelby commented Apr 26, 2019

Uh oh!

conradsp commented Apr 26, 2019 via email

Uh oh!

ippezshelby commented Apr 26, 2019

Uh oh!

ippezshelby commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants