GSoC 2019 Phase 1, 2 & 3 work submission by iosdev747 · Pull Request #14 · openMF/mifos-chatbot

iosdev747 · 2019-06-22T18:56:09Z

overview:

…emplate

ramitsawhney27 · 2019-08-10T20:12:30Z

+import org.mifos.chatbot.core.model.Intent;
+
+class SmallTalk {
+    private static final String[] SMALL_TALK_INTENTS = {


Can we move this to a static file for logical separation, and easy modification later.

made interface SmallTalkService for that. And moved isSmallTalkRequest from SmallTalk.java to SmallTalkHandler.

ramitsawhney27 · 2019-08-10T20:12:49Z

 @Component
 public class ArrearDayHandler extends BaseLoanIntentHandler {
-    private static final String[] INTENT_KEYWORDS = {"arrear", "day"};
+    private static final String[] INTENT_KEYWORDS = {"arrear_day"};


Move to static file

This INTENT_KEYWORDS is specific for this class, so my intention is to keep it here or should i move it?

Keep it here then.

ramitsawhney27 · 2019-08-10T20:13:03Z

 @Component
 public class ClientActivationDateHandler extends BaseLoanIntentHandler {
-    private static final String[] INTENT_KEYWORDS = {"client", "activation", "date"};
+    private static final String[] INTENT_KEYWORDS = {"client_activation_date"};


All such hard coded strings to static files

same as above.

ramitsawhney27 · 2019-08-10T20:13:46Z

 @Component
 public class NextDueDateHandler extends BaseLoanIntentHandler {
-    private static final String[] INTENT_KEYWORDS = {"Due", "Date"};
+    private static final String[] INTENT_KEYWORDS = {"due_date"};


potentially add stemming/lemmatization based matching for these intent keywords?

same as above.

ramitsawhney27 · 2019-08-10T20:14:42Z

+        String intentKeyword = intent.getKeyword().toLowerCase();
+        MifosResponse mifosResponse = new MifosResponse();
+        for(int i=0; i<INTENT_KEYWORDS.length; i++) {
+            if(intentKeyword.equals(INTENT_KEYWORDS[i])) {


Can override equals to an approx equals function here which includes some stemming/lemmatization/general intent based matching rather than exact matches.

These is used to match the intent names predicted by rasa NLU model (most confident one) and those intent names are defined in Rasa dataset (rasa/data/nlu.md) as well as SmallTalkService.java (org/mifos/chatbot/core/SmallTalkService.java) so that's why i used equal rather than partial equal. And for lemmatization i am now using spacy.lemma

ramitsawhney27 · 2019-08-27T09:34:52Z

+```
+create table users_creds
+(
+	username varchar(255) not null,


Can potentially look into encrypting these fields at the database level for when we want to extend this work.

ramitsawhney27 · 2019-08-27T09:35:33Z

 @Component
 public class ArrearDayHandler extends BaseLoanIntentHandler {
-    private static final String[] INTENT_KEYWORDS = {"arrear", "day"};
+    private static final String[] INTENT_KEYWORDS = {"arrear_day"};


Keep it here then.

ramitsawhney27 · 2019-08-27T09:35:46Z

 @Component
 public class ClientActivationDateHandler extends BaseLoanIntentHandler {
-    private static final String[] INTENT_KEYWORDS = {"client", "activation", "date"};
+    private static final String[] INTENT_KEYWORDS = {"client_activation_date"};


ramitsawhney27 · 2019-08-27T09:36:49Z

+        for (String token : input.split(" ")) {
+            try {
+                id = Long.parseLong(token);
+            } catch (NumberFormatException e) {


Should be handled, ideally. If this isn't expected, you should trigger some sort of alerting.

ramitsawhney27 · 2019-08-27T09:37:30Z

+
+    @Override
+    public void onUpdateReceived(Update update) {
+        if (update.hasMessage() && update.getMessage().hasText()) {


sabya48 · 2020-01-23T19:50:07Z

i want to contribute int this project.
hello my name is sabyasachi sarkar from IIT Patna

iosdev474 · 2020-02-27T10:25:55Z

Can this PR be merged so further progress could be done please?

vidakovic · 2020-02-29T16:38:36Z

of course... will do as soon as I'm back at my desk

…

On Thu, Feb 27, 2020, 11:25 Arsh Singh ***@***.***> wrote: Can this PR be merged so further progress could be done please? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14?email_source=notifications&email_token=AAC4ZL5CS42SFGSRZFEQGWLRE6ILJA5CNFSM4H2XMBXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDZYZY#issuecomment-591895655>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC4ZLZ7UCE4KQXLJYPHC7LRE6ILJANCNFSM4H2XMBXA> .

iosdev747 added 30 commits May 28, 2019 20:21

move hardcoded string to application.properties

52b7df4

remove redundant annotation with @SpringBootApplication

47a1854

Update application.properties

f828f47

Add messenger4j dependency

aa4d0c4

Add facebook messenger chat service

a8f706c

Create server config

eb1ceb7

Disable Cross Site Request Forgery(CSRF)

f83519e

temporarily changing slack integration

57456c9

add login method to get credentials

4ed1f07

minor bugs fix in FB messenger integration

458a859

create Basic HTTP auth method

62d95b2

Improve ApiClient constructors

38c93a2

implement authentication in handlers using ApiClient

62f3ebf

create database setting component

a6a565b

add database properties in application.properties

09e198a

create database configuration

c5d6835

Create Database handler

bc34b0d

add database build.gradle

6355f6a

Remove old implementation of JDBC and reimplement with JPA and JDBC t…

4c5180b

…emplate

Create user model, add dependencies and implement query methods

082af69

Update authentication in FB messenger integration

c686347

Minor bug fix in authentication in FB messenger integration

47233e0

remove sout and update authentication logic

6a3ae4f

minor bug fix in authentication (FB messenger integration)

a0e6869

add logic to handle logout

b107e8d

Add telegram API dependency

d2733f0

Integrate telegram bot

bbce0da

Add Telegram database handler methods

a09656a

add login logic to telegram integration

93f456d

minor bug fix with authentication

7aa38f8

iosdev747 added 16 commits July 29, 2019 00:08

Add more intent response

b9a266e

Add handle logic for SmallTalk request in Slack

95571d2

add dependencies for joestelmach parser

3389431

Improve date and id finding logic in RasaNLUService

91a7268

Increase and add response to intents defined in SmallTalkHandler

04447f6

Code cleanup

f23f5cb

Add skypeChatService

5a06fdf

Add skype dependency

90f8552

remove skype as API depreciated

46da0ad

remove skype dependencies

99e5b1f

small bug fix in debug statement

0d12c94

Integrate small talk in facebook messenger and telegram

81ab0a5

Improve intent handlers

c474cb1

Add small talk dataset

bdcb581

Replace Rasa NLU model

f7e84b6

Add slack(deleted accidentally)

be048f8

iosdev747 changed the title ~~GSoC 2019 Phase 1 & 2 work submission~~ GSoC 2019 Phase 1, 2 & 3 work submission Aug 10, 2019

ramitsawhney27 reviewed Aug 10, 2019

View reviewed changes

ramitsawhney27 approved these changes Aug 10, 2019

View reviewed changes

iosdev747 added 7 commits August 11, 2019 15:03

Fix PR review

d846e17

typo fix

95328ea

Code Cleanup

8acf203

Bug fix with message length max limit

7db2089

Update README.md

0355b02

Update README.md with setting up database.

e1a43d8

Added checks to handle exceptions

4595dd5

ramitsawhney27 approved these changes Aug 27, 2019

View reviewed changes

Conversation

iosdev747 commented Jun 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

overview:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sabya48 commented Jan 23, 2020

Uh oh!

iosdev474 commented Feb 27, 2020

Uh oh!

vidakovic commented Feb 29, 2020 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iosdev747 commented Jun 22, 2019 •

edited

Loading