FINERACT-2529: pass externalId instead of null resolvedClientId in Cl…#195
Closed
mansi75 wants to merge 1 commit intoopenMF:developfrom
Closed
FINERACT-2529: pass externalId instead of null resolvedClientId in Cl…#195mansi75 wants to merge 1 commit intoopenMF:developfrom
mansi75 wants to merge 1 commit intoopenMF:developfrom
Conversation
…ientNotFoundException
Collaborator
|
Please raise the PR against apache/develop, not openmf/develop branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ClientApiResource.java, thegetResolvedClientIdmethod throws aClientNotFoundExceptionusingresolvedClientIdvariable. However, this block of code only executes whenresolvedClientIdis null, resulting in an unhelpful error message: "Client with identifier null does not exist."Fix
Passed the
externalIdstring to the exception instead ofresolvedClientId, so the error message accurately reflects which external identifier failed to resolve.