718 technical debt align model field names and serializer names

api_v2/migrations/0079_rename_creatureaction_fields.py

@@ -0,0 +1,26 @@
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('api_v2', '0078_merge_staging_and_crossreference_chains'),
+    ]
+
+    operations = [
+        migrations.RenameField(
+            model_name='creatureaction',
+            old_name='order',
+            new_name='order_in_statblock',
+        ),
+        migrations.RenameField(
+            model_name='creatureaction',
+            old_name='form_condition',
+            new_name='limited_to_form',
+        ),
+        migrations.RenameField(
+            model_name='creatureaction',
+            old_name='legendary_cost',
+            new_name='legendary_action_cost',
+        ),
+    ]

api_v2/models/creature.py

@@ -244,21 +244,21 @@ class CreatureAction(HasName, HasDescription):
         help_text='The type of action used.'
     )
 
-    order = models.SmallIntegerField(
+    order_in_statblock = models.SmallIntegerField(
         blank=True,
         null=True,
         help_text='The position in the list of features that a feature appears in its source statblock'
     )
 
-    form_condition = models.CharField(
+    limited_to_form = models.CharField(
         blank=True,
         null=True,
         default=None,
         max_length=100,
         help_text='Description of form-based conditions for this action.'
     )
 
-    legendary_cost = models.SmallIntegerField(
+    legendary_action_cost = models.SmallIntegerField(
         blank=True,
         null=True,
         default=None,

api_v2/serializers/creature.py

@@ -53,11 +53,6 @@ def get_distance_unit(self, CreatureActionAttack):
 class CreatureActionSerializer(GameContentSerializer):
     attacks = CreatureActionAttackSerializer(many=True, read_only=True)
     usage_limits = serializers.SerializerMethodField()
-
-    # rename model fields to improve readibility of JSON
-    order_in_statblock = serializers.IntegerField(source='order')
-    limited_to_form = serializers.CharField(source='form_condition')
-    legendary_action_cost = serializers.IntegerField(source='legendary_cost')
 
     class Meta:
         model = models.CreatureAction