fix: resolve pipeline reload module caching issue#592
Open
hectorc98 wants to merge 1 commit intoopen-webui:mainfrom
Open
fix: resolve pipeline reload module caching issue#592hectorc98 wants to merge 1 commit intoopen-webui:mainfrom
hectorc98 wants to merge 1 commit intoopen-webui:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Pipeline Reload Module Caching Issue
Problem
The pipeline reload API (
POST /pipelines/reload) was returning HTTP 200 responses but not actually reloading updated pipeline code. Users had to restart the entire pod to see pipeline changes take effect, which defeats the purpose of the reload functionality.Root Cause
Python's module import system caches modules in
sys.modulesby name. Whenload_module_from_path()was called during pipeline reload:importlib.util.spec_from_file_location()would create a module specspec.loader.exec_module()would execute the modulesys.modules, Python would return the cached version instead of re-executing the updated file contentThis meant that pipeline code changes were read from disk but the cached module code continued to execute.
Solution
Added
sys.modulescache clearing inload_module_from_path()before loading modules:Impact
/pipelines/reloadTesting
load_module_from_path()functionFiles Changed
main.py: Addedsys.modulescache clearing and documentationValidation Steps
POST /pipelines/reloadThis fix resolves a significant development experience issue where pipeline changes appeared to be ignored by the reload API.