Skip to content

Fix/faraday instrumentation test coverage#2184

Open
aabhinavvvvvvv wants to merge 3 commits intoopen-telemetry:mainfrom
aabhinavvvvvvv:fix/faraday-instrumentation-test-coverage
Open

Fix/faraday instrumentation test coverage#2184
aabhinavvvvvvv wants to merge 3 commits intoopen-telemetry:mainfrom
aabhinavvvvvvv:fix/faraday-instrumentation-test-coverage

Conversation

@aabhinavvvvvvv
Copy link
Copy Markdown

Summary

Improves test coverage for the faraday instrumentation to meet the 85% SimpleCov threshold (fixes #2156).

  • Rewrites faraday_test.rb to run under the stable appraisal with tests covering name, version, present?, compatible?, and #install on the instrumentation class
  • Adds enable_internal_instrumentation: true test to stable/tracer_middleware_test.rb, old/tracer_middleware_test.rb, and dup/tracer_middleware_test.rb to cover the previously untested else branch in each middleware's call method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve faraday instrumentation test coverage

1 participant