chore: cleanup gemfiles#2182
Merged
arielvalentin merged 2 commits intoopen-telemetry:mainfrom Apr 9, 2026
Merged
Conversation
thompson-tomo
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
github-actions
bot
added
instrumentation-koala
instrumentation-lmdb
instrumentation-mongo
instrumentation-mysql2
instrumentation-net_http
instrumentation-racecar
instrumentation-rack
instrumentation-rdkafka
instrumentation-redis
instrumentation-respec
instrumentation-ruby_kafka
instrumentation-trilogy
propagator-google_cloud_trace_context
propagator-ottrace
propagator-vitess
propagator-xray
resource-detector-container
sampler-xray
instrumentation-http
labels
Contributor
|
I added these because of a warning that it would get removed from gems. Does this mean something else is requiring logger now? |
Contributor
Author
|
Logger has ended up being added twice to the gemfiles. Most of the time it is 2 lines higher/lower. |
thompson-tomo
force-pushed
the
logger_in_gemfiles
branch
from
7bc562d to
da69ac3
Compare
arielvalentin
approved these changes
Apr 9, 2026
Merged
via the queue into
open-telemetry:main
with commit Apr 9, 2026
8f984fe
76 of 77 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the duplicate references to the logger gem in the gemfiles which are currently generating warnings.