test: instrumentation/http - improve test coverage to meet 85% threshold#2174
Open
aabhinavvvvvvv wants to merge 2 commits intoopen-telemetry:mainfrom
Open
test: instrumentation/http - improve test coverage to meet 85% threshold#2174aabhinavvvvvvv wants to merge 2 commits intoopen-telemetry:mainfrom
aabhinavvvvvvv wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
aabhinavvvvvvv
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
previously approved these changes
Apr 7, 2026
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you for catching this! 🚀
kaylareopelle
dismissed
their stale review
Whoops, I misread the CI results. Clearing my approval until we can re-run.
kaylareopelle
changed the title
kaylareopelle
changed the title
kaylareopelle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2157 — the
httpinstrumentation test coverage was below the required 85% threshold due to two silent bugs.Root causes
1. Two connection test files were misnamed
stable/connection.rbandold/connection.rbin the test directory did not match the Rakefile'sFileList['test/**/*_test.rb']glob, so they were never executed.2.
old/connection_test.rbwas brokenThe
beforeblock calledinstrumentation.install({})without settingOTEL_SEMCONV_STABILITY_OPT_IN=old. This causeddetermine_semconvto return'stable', prependingPatches::Stable::Connectioninstead ofPatches::Old::Connection.