ci: Run performance and layout checks in RuboCop#2173
ci: Run performance and layout checks in RuboCop#2173kaylareopelle wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
thompson-tomo
left a comment
thompson-tomo
left a comment
There was a problem hiding this comment.
Sorry for missing performance when I added the commands.
| - name: "Check all ruby files for layout" | ||
| run: | | ||
| set -e # forces exit code to propagate | ||
| npm run check:format:ruby -- --format github |
There was a problem hiding this comment.
This would already be covered as part of https://github.com/kaylareopelle/opentelemetry-ruby-contrib/blob/rubocop-performance-layout/.github/workflows/ci-markdown-checks.yml#L167-L168
| "check:lint:markdown": "markdownlint-cli2 '**/*.md'", | ||
| "check:lint:renovate": "renovate-config-validator", | ||
| "check:lint:ruby": "rubocop --only Lint,Naming,Style", | ||
| "check:performance:ruby": "rubocop --only Performance", |
There was a problem hiding this comment.
We should also have a write command.
And also add performance to both the check & write command.
There was a problem hiding this comment.
What do you think about adding performance to one of the existing checks rather than making it its own check? We don't have anything other performance checking tools to group it with. Could it fit with check:source:ruby?
There was a problem hiding this comment.
Sure that works for me.
No problem! Thanks for your help with this PR. It's helping me catch up on the CI changes that have happened while I've been away. |
2 participants
The refactor to run Rubocop using NPM in #1974 missed a few Departments: Layout and Performance. This PR makes sure those departments are run as part of the checks.