test(net-http): improve instrumentation coverage#2172
test(net-http): improve instrumentation coverage#2172mateenali66 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
@mateenali66 thanks for this, the Workflow override is yet to have been merged into main. We will review and come back to you. |
|
sounds good, no rush. once the workflow override is merged i can pick up the remaining coverage issues too (httpx etc). |
|
@mateenali66 could you take a look at the CI error:
And also remove the extra new line from the end of both files to fix that ci issue. |
…teen Anjum <mateenali66@gmail.com> Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
remove trailing blank lines in net_http test files Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
71861b1 to
eee620c
Compare
|
@thompson-tomo fixed both, require_relative paths corrected and trailing blank lines removed. also added missing sign-off on the second commit. |
adds targeted unit tests for net_http helper and instrumentation config paths to improve coverage.
what's included:
HttpHelpermethod normalization, unknown methods, andurl.templatespan namingstable,dup,old) andsplit_path_and_queryrefs #2160