test: run simplecov on all frameworks using collated reports#2136
Open
thompson-tomo wants to merge 26 commits intoopen-telemetry:mainfrom
Open
test: run simplecov on all frameworks using collated reports#2136thompson-tomo wants to merge 26 commits intoopen-telemetry:mainfrom
thompson-tomo wants to merge 26 commits intoopen-telemetry:mainfrom
Conversation
thompson-tomo
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
thompson-tomo
changed the title
thompson-tomo
changed the title
Contributor
Author
|
Anthropic addressed via #2137 |
Added a step to set coverage threshold based on gem type.
This was referenced Apr 5, 2026
kaylareopelle
approved these changes
Apr 7, 2026
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks for noticing this and fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures test coverage is meet on all frameworks to avoid potential issues when bumping min frameworks. This also addresses that the min coverage is not actually currently being enforced due to coverage only being set after the tests have run.
To Address failures due to insufficient coverage the min coverage is being overwritten using a yml file in the working directory. This ensures the definition of that gem and all required inputs resides within the gem folder and pr's can be appropriately labelled.
Here is an example of where the min coverage was not meet (increased for testing to 99) but check still passed: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/23683365227/job/68998870234?pr=2136.
See after changes, with the key being the % is now correct
