Skip to content

Make ConcurrentMultiSpanProcessor fork safe #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregoiredx wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Make ConcurrentMultiSpanProcessor fork safe #4862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import concurrent.futures
import json
import logging
import os
import threading
import traceback
import typing
Expand Down Expand Up @@ -238,8 +239,16 @@ def __init__(self, num_threads: int = 2):
# iterating through it on "on_start" and "on_end".
self._span_processors = () # type: Tuple[SpanProcessor, ...]
self._lock = threading.Lock()
self._executor = concurrent.futures.ThreadPoolExecutor(
max_workers=num_threads
self._num_threads = num_threads
self._executor = self._build_executor()
if hasattr(os, "register_at_fork"):
# Only the main thread is kept in forked processed, the executor
# needs to be re-instantiated to get a fresh pool of threads:
os.register_at_fork(after_in_child=self._build_executor)

def _build_executor(self) -> concurrent.futures.ThreadPoolExecutor:
return concurrent.futures.ThreadPoolExecutor(
max_workers=self._num_threads
)

def add_span_processor(self, span_processor: SpanProcessor) -> None:
Expand Down