feat(collector): use mutex for locking struct fields but still allowi… #2091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the reading and parsing of the request bodies to happen concurrently
wpessers
commented
Dec 23, 2025
|
|
||
| // httpHandler handles the requests coming from the Telemetry API. | ||
| // Everytime Telemetry API sends events, this function will read them from the response body | ||
| // and put into a synchronous queue to be dispatched later. |
Contributor
Author
There was a problem hiding this comment.
Also this seems incorrect? I only see that queue being used in a debug log down below...
Contributor
There was a problem hiding this comment.
I noticed this as well, we can remove it.
herin049
approved these changes
Dec 23, 2025
wpessers
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng the reading and parsing of the request bodies to happen concurrently