-
Notifications
You must be signed in to change notification settings - Fork 920
Implement SDK metrics for trace #7895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anuraaga
wants to merge
2
commits into
open-telemetry:main
Choose a base branch
from
anuraaga:trace-internal-telemetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| Comparing source compatibility of opentelemetry-sdk-trace-1.57.0-SNAPSHOT.jar against opentelemetry-sdk-trace-1.56.0.jar | ||
| No changes. | ||
| *** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.sdk.trace.export.BatchSpanProcessorBuilder (not serializable) | ||
| === CLASS FILE FORMAT VERSION: 52.0 <- 52.0 | ||
| +++ NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.trace.export.BatchSpanProcessorBuilder setInternalTelemetryVersion(io.opentelemetry.sdk.common.InternalTelemetryVersion) | ||
| +++ NEW INTERFACE: PUBLIC(+) ABSTRACT(+) STATIC(+) io.opentelemetry.sdk.trace.export.SpanProcessorMetrics$LongCallable (not serializable) | ||
| +++ CLASS FILE FORMAT VERSION: 52.0 <- n.a. | ||
| +++ NEW SUPERCLASS: java.lang.Object | ||
| +++ NEW METHOD: PUBLIC(+) ABSTRACT(+) long get() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracerMetrics.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.sdk.trace; | ||
|
|
||
| import static io.opentelemetry.api.common.AttributeKey.stringKey; | ||
|
|
||
| import io.opentelemetry.api.common.AttributeKey; | ||
| import io.opentelemetry.api.common.Attributes; | ||
| import io.opentelemetry.api.metrics.LongCounter; | ||
| import io.opentelemetry.api.metrics.LongUpDownCounter; | ||
| import io.opentelemetry.api.metrics.Meter; | ||
| import io.opentelemetry.api.metrics.MeterProvider; | ||
| import io.opentelemetry.api.trace.SpanContext; | ||
| import io.opentelemetry.sdk.trace.samplers.SamplingDecision; | ||
|
|
||
| /** | ||
| * SDK metrics exported for started and ended spans as defined in the <a | ||
| * href="https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/#span-metrics">semantic | ||
| * conventions</a>. | ||
| */ | ||
| final class SdkTracerMetrics { | ||
|
|
||
| // Visible for testing | ||
| static final AttributeKey<String> OTEL_SPAN_PARENT_ORIGIN = stringKey("otel.span.parent.origin"); | ||
| // Visible for testing | ||
| static final AttributeKey<String> OTEL_SPAN_SAMPLING_RESULT = | ||
| stringKey("otel.span.sampling_result"); | ||
|
|
||
| private final LongCounter startedSpans; | ||
| private final LongUpDownCounter liveSpans; | ||
|
|
||
| SdkTracerMetrics(MeterProvider meterProvider) { | ||
| Meter meter = meterProvider.get("io.opentelemetry.sdk.trace"); | ||
|
|
||
| startedSpans = | ||
| meter | ||
| .counterBuilder("otel.sdk.span.started") | ||
| .setUnit("{span}") | ||
| .setDescription("The number of created spans.") | ||
| .build(); | ||
| liveSpans = | ||
| meter | ||
| .upDownCounterBuilder("otel.sdk.span.live") | ||
| .setUnit("{span}") | ||
| .setDescription( | ||
| "The number of created spans with recording=true for which the end operation has not been called yet.") | ||
| .build(); | ||
| } | ||
|
|
||
| /** | ||
| * Records metrics for when a span starts and returns a {@link Runnable} to execute when ending | ||
| * the span. | ||
| */ | ||
| Runnable startSpan(SpanContext parentSpanContext, SamplingDecision samplingDecision) { | ||
| startedSpans.add( | ||
| 1, | ||
| Attributes.of( | ||
| OTEL_SPAN_PARENT_ORIGIN, | ||
| parentOrigin(parentSpanContext), | ||
| OTEL_SPAN_SAMPLING_RESULT, | ||
| samplingDecision.name())); | ||
|
|
||
| if (samplingDecision == SamplingDecision.DROP) { | ||
| return () -> {}; | ||
| } | ||
|
|
||
| Attributes liveSpansAttributes = | ||
| Attributes.of(OTEL_SPAN_SAMPLING_RESULT, samplingDecision.name()); | ||
| liveSpans.add(1, liveSpansAttributes); | ||
| return () -> liveSpans.add(-1, liveSpansAttributes); | ||
| } | ||
|
|
||
| private static String parentOrigin(SpanContext parentSpanContext) { | ||
| if (!parentSpanContext.isValid()) { | ||
| return "none"; | ||
| } | ||
| if (parentSpanContext.isRemote()) { | ||
| return "remote"; | ||
| } | ||
| return "local"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name did remind me of span processors, but it seemed we still need this in addition to them since the span metrics aren't tied to any specific processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree - and it wouldn't be easy to add it to the active processor, as the runnable captures the sampling decision from start span.
Maybe it would be easier to follow when the variable would be named
recordMetrics.