Fix RocketMQ context propagation for batch messages in version 5.3.4+#15559
Closed
Arunodoy18 wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Fix RocketMQ context propagation for batch messages in version 5.3.4+#15559Arunodoy18 wants to merge 2 commits intoopen-telemetry:mainfrom
Arunodoy18 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Context propagation was not working correctly for batch messages in RocketMQ 5.0+ because all messages in a batch were sharing the same receive span context instead of each message having its own context extracted from message properties. Changes: - Modified ReceiveSpanFinishingCallback to extract individual context for each message in the batch using MessageMapGetter to read trace headers - Each message now gets its own properly linked context for correct tracing - Re-enabled testRocketmqProduceAndBatchConsume test for latest dependencies This fixes the issue where batch message consumers would not properly propagate trace context from producers, breaking distributed tracing for RocketMQ batch message processing in versions 5.3.4+. Resolves the disabled test from open-telemetry#15512
Member
|
Moving to draft, please move back to ready to review once the tests are passing. |
laurit
reviewed
Dec 7, 2025
| null, | ||
| timer.startTime(), | ||
| timer.now()); | ||
| // For batch messages, each message should have its own context that properly |
Contributor
There was a problem hiding this comment.
As pointed out in #15523 (comment) this won't work.
laurit
added
the
needs author feedback
Contributor
|
This PR has been labeled as stale due to lack of activity and needing author feedback. It will be automatically closed if there is no further activity over the next 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context propagation was not working correctly for batch messages in RocketMQ 5.0+ because all messages in a batch were sharing the same receive span context instead of each message having its own context extracted from message properties.
Changes:
This fixes the issue where batch message consumers would not properly propagate trace context from producers, breaking distributed tracing for RocketMQ batch message processing in versions 5.3.4+.
Resolves the disabled test from #15512