-
Notifications
You must be signed in to change notification settings - Fork 1k
Add system properties bridge #15339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeitlinger
wants to merge
48
commits into
open-telemetry:main
Choose a base branch
from
zeitlinger:system-properties-bridge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+476
−121
Open
Add system properties bridge #15339
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
51a532f
add system properties bridge
zeitlinger 68d64c8
add system properties bridge
zeitlinger 2acda70
add tests
zeitlinger edc6d1c
add list
zeitlinger a78bf62
refactor
zeitlinger ac66918
refactor
zeitlinger 91b03f3
string
zeitlinger 6aa96f1
string
zeitlinger fff5430
string
zeitlinger 25f2ea3
string
zeitlinger 1946fd5
string
zeitlinger 6abc0e3
string
zeitlinger 9bec486
string
zeitlinger 74f7221
string
zeitlinger ee0046e
javadoc
zeitlinger 4128283
add contract
zeitlinger 69d5bc6
add contract
zeitlinger 2db4921
remove contract
zeitlinger 4d5340d
remove contract
zeitlinger 05d3ede
inline method to avoid class not found exception for DeclarativeConfi…
zeitlinger 501a769
pr review
zeitlinger 5c30b44
use optional instead of providing default for boolean
zeitlinger c5c34ed
use optional instead of providing default for int
zeitlinger 7ca08d7
use optional instead of providing default for list
zeitlinger 1d72e01
use optional instead of providing default for string
zeitlinger 669236a
fix
zeitlinger e7072ba
fix
zeitlinger d921bab
fix
zeitlinger 6724cb7
split pr
zeitlinger d1a9784
split pr
zeitlinger 41aac72
fix
zeitlinger 9245a86
fix
zeitlinger 278259e
pr review
zeitlinger a3fbf23
revert aws test
zeitlinger 93adb59
use "/development" instead of "experimental" in declarative config
zeitlinger 7c81df5
use "/development" instead of "experimental" in declarative config
zeitlinger 7bc8ed9
fix
zeitlinger 91b0050
docs
zeitlinger d9f56ba
avoid double bridge
zeitlinger b542ea1
normalize system props before lookup to avoid ambiguity of "experimen…
zeitlinger 6c889a7
normalize system props before lookup to avoid ambiguity of "experimen…
zeitlinger 2cc9cf0
normalize system props before lookup to avoid ambiguity of "experimen…
zeitlinger fe2886b
normalize system props before lookup to avoid ambiguity of "experimen…
zeitlinger c9d0e19
Merge branch 'main' into system-properties-bridge
zeitlinger d7d0ba8
rename js snippet property
zeitlinger d2f1b6b
normalize system props before lookup to avoid ambiguity of "experimen…
zeitlinger 037aebb
add changelog
zeitlinger b0079bd
format
zeitlinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be unified now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can if we accept another breaking change (the common part)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I missed that, this one may be more used, can you open an issue to change it in next major version bump (3.0)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#15566