declarative config: early init and property mapping#14184
declarative config: early init and property mapping#14184trask merged 78 commits intoopen-telemetry:mainfrom
Conversation
ea7fdfd to
a36770e
Compare
This still leaves "otel.javaagent.enabled" - which promises not to touch anything if the value is |
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfiguration.java doesn't log for the method that we call - but jackson can throw exceptions (which I can buffer like |
How can we find out if that's the case? E.g. a tool to compare loaded classes against what we want to transform. |
extracted ErrorBuffer: https://github.com/zeitlinger/opentelemetry-java-instrumentation/blob/eb8ee1978206d602db9e07b02e09b36e01d3cad3/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/ErrorBuffer.java |
|
@laurit please have a look 😄 |
3524434 to
682b5e0
Compare
1e27b90 to
548e56c
Compare
|
🔧 The result from spotlessApply was committed to the PR branch. |
811b037 to
b0c18d3
Compare
|
@laurit please check again |
This reverts commit 643b8f8.
a8aeebf to
413ec6d
Compare
…emetry#14184)" This reverts commit 12dac23.
Fixes #14133
Fixes #14132
Fixes #14160
Integration test already existed before:
opentelemetry-java-instrumentation/instrumentation/methods/javaagent/build.gradle.kts
Lines 22 to 36 in 4251217