Skip to content

jmx scraper remove usage of deprecated API #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 3 commits into from
Jan 5, 2026
Merged

jmx scraper remove usage of deprecated API #2526

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70eb09f
jmx scraper remove usage of deprecated API
SylvainJuge Dec 16, 2025
110626b
handle IOException even if unlikely to be thrown
SylvainJuge Dec 16, 2025
3247c0b
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-c…
SylvainJuge Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 10 additions & 26 deletions jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
import java.io.InputStream;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
Expand Down Expand Up @@ -240,30 +238,16 @@ private static JmxTelemetry createJmxTelemetry(
JmxTelemetryBuilder builder = JmxTelemetry.builder(openTelemetry);
builder.beanDiscoveryDelay(config.getSamplingInterval());

// Unfortunately we can't use the convenient 'addClassPathRules' here as it does not yet
// allow to customize the path of the yaml resources in classpath.
// config.getTargetSystems().forEach(builder::addClassPathRules);
//
// As a temporary workaround we load configuration through temporary files and register them
// as if they were custom rules.
config
.getTargetSystems()
.forEach(
system -> {
try (InputStream input = config.getTargetSystemYaml(system)) {
Path tempFile = Files.createTempFile("jmx-scraper-" + system, ".yaml");
try {
Files.copy(input, tempFile, StandardCopyOption.REPLACE_EXISTING);
builder.addCustomRules(tempFile);
} finally {
Files.delete(tempFile);
}
} catch (IOException e) {
throw new IllegalStateException(e);
}
});

config.getJmxConfig().stream().map(Paths::get).forEach(builder::addCustomRules);
for (String system : config.getTargetSystems()) {
try (InputStream input = config.getTargetSystemYaml(system)) {
builder.addRules(input);
} catch (IOException e) {
// can only be triggered by close(), thus very unlikely to be triggered in practice
throw new IllegalStateException("IO error loading rules for system: " + system, e);
}
}

config.getJmxConfig().stream().map(Paths::get).forEach(path -> builder.addRules(path));
return builder.build();
}

Expand Down