Open
Conversation
Change only applies to Geojson featureCollection type
add tickformat delete console.log delete unused import set tip to null deleted unused data files change storymap file name
| ></osl-geo> | ||
| <osl-geo | ||
| data="http://localhost:6006/data/walmarts.json" | ||
| fy="(d) => d.properties.date" |
Contributor
There was a problem hiding this comment.
Given some shared ownership of the faceting and some confusion that could come up, do you think we should migrate all faceting up to the plot component?
Collaborator
Author
There was a problem hiding this comment.
Yes, this is what we're pursuing here. The facet functionality is integrated within the plot component through fyInterval="10 years". In the geo mark, fy="(d) => d.properties.date" serves the purpose of specifying the specific column or variable employed for faceting. Does that sounds fair or is there any other specific results that you would like to see as a property for the plot component?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces the faceting feature of the Geo Mark component. The visual representation is akin to a comic strip, depicting the historical opening locations of Walmart stores over past decades.
Demo
Notes
The imported data for Geo Mark is in GeoJSON format. I've updated the store.ts code to parse properties using the GeoJSON FeatureCollection type. In the future, the data file format will be in WKT format and undergo transformation into GeoJSON format post-loading.
Testing Instructions