Open
Conversation
6b94852 to
92175ea
Compare
On FreeBSD, one must actually link against libpcap (or give the path to a shared object at link time). That is, it is not a header-only library on that platform. Account for this by adding a new boolean variable in `platform-quirks.cmake`: `NEED_PCAP_LIBRARY`, which defaults to false. Condition pcap library discovery and link argument modifications on that variable in `FindPCAP.cmake` and `dep-link.cmake`.
Author
|
Gentle ping on this? |
Contributor
|
FYI, the makefile build produces completely useful simulators with PCAP network support that works just fine on FreeBSD 14.3. I suspect the same with 15.0. |
Author
|
Yes. But not with cmake. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD, one must actually link against libpcap (or give the path to a shared object at link
time). That is, it is not a header-only library
on that platform.
Account for this by adding a new boolean variable
in
platform-quirks.cmake:NEED_PCAP_LIBRARY,which defaults to false. Condition pcap library
discovery and link argument modifications on that
variable in
FindPCAP.cmakeanddep-link.cmake.