Not finding vmnet shouldn't be a fatal error#488
Open
NattyNarwhal wants to merge 3 commits intoopen-simh:masterfrom
Open
Not finding vmnet shouldn't be a fatal error#488NattyNarwhal wants to merge 3 commits intoopen-simh:masterfrom
NattyNarwhal wants to merge 3 commits intoopen-simh:masterfrom
Conversation
Allows the build to continue if vmnet isn't supported, either because the deployment target is too old (before 10.10) or the compiler lacks support for blocks (GCC).
Contributor
|
You should fix the makefile with appropriate tests as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the build to continue if vmnet isn't supported, either because the deployment target is too old (before 10.10) or the compiler lacks support for blocks (GCC).
See GH-486. I don't have an older Mac handy to test this with.