Skip to content

Conversation

@BelfordZ
Copy link
Member

Summary

  • stop router handler from replying to JSON-RPC notifications
  • filter notifications from HTTP/HTTPS/WebSocket/IPC responses
  • add tests for notification handling

Testing

  • npm test
  • npm run lint

https://chatgpt.com/codex/tasks/task_e_68b362c26dc0832fad10379451e75d66

@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.11%. Comparing base (eee4a4d) to head (1197bbe).

Files with missing lines Patch % Lines
src/transports/http.ts 57.14% 6 Missing ⚠️
src/transports/https.ts 57.14% 6 Missing ⚠️
src/transports/ipc.ts 77.77% 2 Missing ⚠️
src/transports/websocket.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   98.96%   94.11%   -4.85%     
==========================================
  Files           9        9              
  Lines         289      323      +34     
  Branches       43       49       +6     
==========================================
+ Hits          286      304      +18     
- Misses          3       19      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants