feature/Add start_at_departure flag for GoToPlace#467
Conversation
Signed-off-by: kjchee <keai_jiang_chee@cgh.com.sg>
mxgrey
left a comment
There was a problem hiding this comment.
I left one remark, but it's not a blocker.
We just need to wait for open-rmf/rmf_task#128 to be merged, and then we can merge this one.
| "required": ["category"] | ||
| }, | ||
| "start_at_departure": { | ||
| "type": "boolean", |
There was a problem hiding this comment.
It's not important, but I think we can add
"default": false,to this definition.
https://json-schema.org/understanding-json-schema/reference/annotations
There was a problem hiding this comment.
sure, will add it in
…schema Signed-off-by: kjchee <keai_jiang_chee@cgh.com.sg>
mxgrey
left a comment
There was a problem hiding this comment.
I've tried this PR out with the help of open-rmf/rmf_demos#331 and the new behavior is working exactly as expected.
Thanks for the contribution!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=========================================
- Coverage 17.61% 0 -17.62%
=========================================
Files 209 0 -209
Lines 19351 0 -19351
Branches 9297 0 -9297
=========================================
- Hits 3409 0 -3409
+ Misses 12274 0 -12274
+ Partials 3668 0 -3668
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
New feature implementation
Implemented feature
This PR is related to this open-rmf/rmf_task#128.
Implementation description
start_at_departureis added in go_to_place schema.GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: