Complete roundtrip of PL <--> OPB MD conversion#87
Open
Conversation
Does not try to retain assets, or defined asset values, and loses the types of non string customizations currently.
- Add missing section to md result we cannot roundtrip right now - Move imports to a dedicated sections with a comment - Using `ast.literal_eval`, customizations that are literals are parsed back from strings to their native type
now attempts to list assets found in the 4 key folders from prairielearn
Need to flatten the namedtuple to a list
- Now copies asset files - Allows for an output directory and filename to be passed - Validates input paths are directories and not files - Improves argument checking
Collaborator
Author
|
Benchmark of what output looks like as of August 11th, 2023: https://gist.github.com/Bluesy1/6f497bc1ed5b4a3aae25f91918abe2ad |
- Need to prevent `"..."` from being evaled to the `Ellipses` literal - Remove the `__pycache__` directory created by importing and executing the `server.py` file - Fix `server.py` parsing - Fix asset copying - Add `pl-rich-text-editor` to list of supported pl inputs
Now should upload md generated from pl files on failure
…metadata field of the comment object in `info.json`
Collaborator
Author
|
For now, to make the roundtrip possible, I've shoved all the extra keys I can't get normally into a nested object inside the comment section of the I expect this will need multiple rounds of review since its a fairly large change, but it should be mostly feature complete now and working. |
Merged
Start fixing bugs/issues in tests causing failures
…if one on a question already fails.
5d27a03 to
5e18acf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the PL to/from OPB MD roundtrip
TODO:
Resolves #86