Skip to content

Add owner incident deletion UI#60

Merged
TheSilkky merged 1 commit into
developfrom
issue-48-owner-incident-deletion-ui
Jun 6, 2026
Merged

Add owner incident deletion UI#60
TheSilkky merged 1 commit into
developfrom
issue-48-owner-incident-deletion-ui

Conversation

@TheSilkky

Copy link
Copy Markdown
Member

Summary

  • Adds typed owner incident deletion status and request API client methods for the current server contract.
  • Adds an authenticated incident-detail deletion section with independent status loading and generic errors.
  • Requires explicit confirmation before sending an open-incident deletion request and uses the fixed non-sensitive account_delete reason code.
  • Documents the deletion-route boundary and updates current scope notes.

Validation

  • npm run typecheck
  • npm run lint
  • npm run test
  • npm run build
  • npm run test:e2e
  • git diff --check

Security / Scope Notes

  • Frontend-only change; no backend routes or admin/operator behavior added.
  • Does not add browser decryption, key unwrapping, recording, export playback, emergency dispatch, or production-readiness claims.
  • Deletion schemas and UI avoid retaining or displaying deletion item paths, object keys, request bodies, plaintext, raw keys, wrapped-key ciphertext, token hashes, private deployment details, or user safety narrative.

Closes #48

@TheSilkky TheSilkky changed the title [codex] Add owner incident deletion UI Add owner incident deletion UI Jun 6, 2026
@TheSilkky

Copy link
Copy Markdown
Member Author

@codex review

Please review this PR for correctness, security, scope control, tests, and consistency with README.md, AGENTS.md, SECURITY.md, and relevant docs.

Focus on frontend route behavior, API client assumptions against open-proofline/server, token handling, no secret logging, no browser decryption or key unwrapping, Catalyst licensing boundaries, and validation results.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@TheSilkky TheSilkky marked this pull request as ready for review June 6, 2026 02:38
@TheSilkky TheSilkky merged commit 12cba70 into develop Jun 6, 2026
1 check passed
@TheSilkky TheSilkky deleted the issue-48-owner-incident-deletion-ui branch June 6, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Owner Incident Deletion Status And Request UI

1 participant