Merged
Conversation
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Fixes the SearchPatient2Action to match pre-migration behavior: - Labs linked to patient now open e-chart directly - Unlinked labs show patient search page - Added OWASP Encoder for URL parameters - Added comprehensive JavaDoc documentation
- Move request/response initialization inside execute() method - Add null safety checks for required parameters (labNo, labType)
…haviour, sort by ASC
…scending to match other parts of the flowsheet, like measurements
- Remove problematic base tag that pointed to wrong directory
- Add JSTL core taglib and use EL expressions throughout
- Implement OWASP Encode.forUriComponent() for sex/age parameters
- Convert all relative calculator paths to absolute paths using ${ctx}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Change from Encode.forUriComponent() to Encode.forJavaScriptAttribute() for sex/age parameters used in JavaScript onclick attributes - Fix CSS path from /encounterStyles.css to correct location at /oscarEncounter/encounterStyles.css Co-authored-by: Deval Italiya <D3V41@users.noreply.github.com>
…c to ensure any conditionals, or queries with the expected module issue field will be allowed
…null check to module SQL utility function, added null safety to demographic checks in document jsp files
…is null, normalized modules if the values is uppercase
…nal logic to check for null moduleid before checking potential null value
…or module, added updated javadoc comment about new method thorwing error if module is null
…e are any more data inconsistencies they work with it as well
…re instance-based The static `clientKeystore` variable in EdtClientBuilder was shared between MCEDT and HCV services, causing a race condition where HCV validation would overwrite the MCEDT keystore path. This resulted in MCEDT upload failures after HCV validation operations.
Enhance JavaDoc documentation for setClientKeystoreFilename and setExternalClientKeystoreFilename methods to comply with CLAUDE.md standards. Added detailed descriptions, @param tags with specific data types, and @SInCE tags based on git history. - EdtClientBuilder.setClientKeystoreFilename: Added context about instance-based keystore paths preventing race conditions - DelegateFactory/OnlineHCValidator/EDTBaseTest: Converted C-style comments to proper JavaDoc with comprehensive parameter documentation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Per CLAUDE.md documentation standards, @SInCE tags must use accurate dates from git history. Updated all keystore configuration method JavaDoc to reflect the actual commit date of these changes. Co-authored-by: Deval Italiya <D3V41@users.noreply.github.com>
…ing fallback logic for no printstyle dropdown option, which is the current behaviour of preventions
…er-icon-billing' into hotfix-package
…verted-logic' into hotfix-package
…t-date' into hotfix-package
…ntion-order' into hotfix-package
…mes' into hotfix-package
…sp-encoding-4' into hotfix-package
…es-are-not-displaying' into hotfix-package
…condition' into hotfix-package
…load' into hotfix-package
…ickler' into hotfix-package
…ues' into hotfix-package
…ces-signature' into hotfix-package
…leading-dashes' into hotfix-package
…-through-flowsheets' into hotfix-package
23 tasks
warrendennis
requested changes
Feb 24, 2026
| @@ -0,0 +1,373 @@ | |||
| /** | |||
| * Copyright (c) 2026. Magenta Health. All Rights Reserved. | |||
Collaborator
There was a problem hiding this comment.
Please remove these, copyright headings.
Contributor
Author
|
We will get this up to date with main |
Contributor
Author
|
@warrendennis the copyright headings have been removed and this branch has been made up to date with |
warrendennis
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains fixes for bugs that were flagged at MHI, as well as a couple gaps that were identified during OMD Validation.
This branch (
hotfix-package) builds on top of PR #188 and includes 14 additional bug fixes and performance improvements that were merged afteropeno-beta:staging/01232026was created.Individual PRs in this package (beyond PR #188)
1. PR #1987 - Fix issue where billings created from a past encounter/appointment had the wrong service date prefilled (3 commits)
Related Issue: #1989
2. PR #2061 - Fix lab E-Chart button opening search for already-linked patients (2 commits)
Related Issue: #2059
3. PR #2063 - Fix reversed prevention ordering (2 commits)
Related Issue: #2064
4. PR #2101 - Fix: reverse flowsheets prevention order, now descending instead of ascending to match other parts of the flowsheet, like measurements (1 commit)
Related Issue: #2065
5. PR #2110 - Fix: Slow tickler load times (8 commits)
Related Issue: #2106
6. PR #2187 - Fix calculator page 404 errors and add OWASP encoding for security (5 commits)
Related Issue: #2102
7. PR #2219 - Fix: legacy documents and doc types not display correctly (6 commits)
Related Issue: #2218
8. PR #2228 - Fix MCEDT/HCV keystore race condition causing upload failures (6 commits)
Related Issue: #2227
9. PR #2258 - MCEDT multiple file download security processing error (11 commits)
Related Issue: #2236
10. PR #2257 - Performance: DTO Projection Tickler on read operations (11 commits)
Related Issue: #2106
11. PR #2266 - Fix: consultation sorting issues, updated XSS security on consultation page (5 commits)
Related Issue: #2260
12. PR #2275 - Fix: missing textbox to edit signature in preferences when no signature is set on the currently logged in provider (2 commits)
Related Issue: #2272
13. PR #2271 - MDS lab tests with leading dashes not displaying in labDisplay.jsp (4 commits)
Related Issues: #2269, #2270
14. PR #2276 - Fix: preventions not being included in flowsheet printing (3 commits)
Related Issue: #2274
Summary Statistics: